Recognise empty scale with limits = <function>
as empty
#5948
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #5945.
Briefly, a discrete position scale was treated as empty when range data is absent and limits are
NULL
.This PR also treats such scale as empty when range data is absent and limits is a function.
In such cases, functions don't recieve proper 'natural data limits' because the range data is absent.
Potentially, this would cause troubles downstream, so I thought it best to treat such cases as empty scales.
Reprex from issue, note the empty plot instead of errors:
Created on 2024-06-19 with reprex v2.1.0